Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use Doctrine metadata even when persist is disabled #841

Conversation

nikophil
Copy link
Member

@nikophil nikophil commented Mar 7, 2025

see #838 (comment)

when persist is disabled with ->withoutPersisting() but persistence still available, we should still rely on Doctrine metadata

ping @vincentchalamon

@nikophil nikophil force-pushed the fix/use-doctrine-metadata-even-when-persist-disabled branch from 0ae9fa6 to 0cab827 Compare March 7, 2025 17:47
@nikophil nikophil changed the title fix/use doctrine metadata even when persist disabled fix: use Doctrine metadata event when persist is disabled Mar 7, 2025
@nikophil nikophil changed the title fix: use Doctrine metadata event when persist is disabled fix: use Doctrine metadata even when persist is disabled Mar 7, 2025
@nikophil nikophil merged commit 2f523df into zenstruck:2.3.x Mar 7, 2025
66 checks passed
@nikophil nikophil deleted the fix/use-doctrine-metadata-even-when-persist-disabled branch March 7, 2025 17:56
nikophil added a commit that referenced this pull request Mar 10, 2025
* 2.3.x:
  bot: fix cs [skip ci]
  fix: bug with factory collectin of persistent factory in unit test (#842)
  fix: use Doctrine metadata event when persist is disabled (#841)
  minor: add parameter "withAutoRefresh" to unproxy() function (#840)
  chore: upgrade also dama when upgrading phpunit version (#839)
  bot: fix cs [skip ci]
  changelog: update [skip ci]
  fix: can call ->create() in after persist callback (#833)
nikophil added a commit that referenced this pull request Mar 10, 2025
* fix: can call ->create() in after persist callback (#833)

* changelog: update [skip ci]

* bot: fix cs [skip ci]

* chore: upgrade also dama when upgrading phpunit version (#839)

* minor: add parameter "withAutoRefresh" to unproxy() function (#840)

* fix: use Doctrine metadata event when persist is disabled (#841)

* fix: bug with factory collectin of persistent factory in unit test (#842)

* bot: fix cs [skip ci]

* fix: add missing Test attribute

---------

Co-authored-by: nikophil <[email protected]>
nikophil added a commit to nikophil/foundry that referenced this pull request Mar 31, 2025
* 2.3.x:
  bot: fix cs [skip ci]
  fix: handle "inverse one to one" without "placeholder" solution (zenstruck#855)
  bot: fix cs [skip ci]
  feat: add force() helper (zenstruck#854)
  chore: add support for doctrine/persistence 4 (zenstruck#852)
  fix: fix doctrine collection with union/intersection type (zenstruck#847)
  bot: fix cs [skip ci]
  fix: bug with factory collectin of persistent factory in unit test (zenstruck#842)
  fix: use Doctrine metadata event when persist is disabled (zenstruck#841)
  minor: add parameter "withAutoRefresh" to unproxy() function (zenstruck#840)
  chore: upgrade also dama when upgrading phpunit version (zenstruck#839)
  bot: fix cs [skip ci]
  changelog: update [skip ci]
  fix: can call ->create() in after persist callback (zenstruck#833)
@nikophil nikophil mentioned this pull request Mar 31, 2025
nikophil added a commit that referenced this pull request Mar 31, 2025
* fix: can call ->create() in after persist callback (#833)

* changelog: update [skip ci]

* bot: fix cs [skip ci]

* chore: upgrade also dama when upgrading phpunit version (#839)

* minor: add parameter "withAutoRefresh" to unproxy() function (#840)

* fix: use Doctrine metadata event when persist is disabled (#841)

* fix: bug with factory collectin of persistent factory in unit test (#842)

* bot: fix cs [skip ci]

* fix: fix doctrine collection with union/intersection type (#847)

* fix: fix hydrator with doctrine collections using intersection types

* feat: add unit tests for hydrator

* test: add functional test for union type

---------

Co-authored-by: Nicolas PHILIPPE <[email protected]>

* chore: add support for doctrine/persistence 4 (#852)

* feat: add force() helper (#854)

* bot: fix cs [skip ci]

* fix: handle "inverse one to one" without "placeholder" solution (#855)

* fix: one to one no more uses placeholder

* fix: use different error message if types are missing

* bot: fix cs [skip ci]

* changelog: update

---------

Co-authored-by: nikophil <[email protected]>
Co-authored-by: Maarten de Boer <[email protected]>
Co-authored-by: chris <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant